[artifactory-ha] stateful set spec.serviceName should match the service created #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
kpirateone
changed the title
|
recheckcla |
|
We decided not to implement this change as this might have impact on our current deployments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
currently the service generated from artifactory service creates a service with name:
artifactory-ha.fullname. the artifactory-node-statefulset.yaml creates a spec.serviceName asartifactory-ha.node.name. the service specified in the statefulset needs to align, particularly when addressing pods directly in kubernetes DNS : https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/this pr changes the service creation to have the same name as specified in the node statefulset spec.serviceName
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #none
Special notes for your reviewer:
@eldada @rimusz @danielezer